Skip to content
This repository has been archived by the owner on Oct 31, 2022. It is now read-only.

Consider versions from Gradle BOM Files #127

Closed
jkasten2 opened this issue Jun 13, 2020 · 1 comment
Closed

Consider versions from Gradle BOM Files #127

jkasten2 opened this issue Jun 13, 2020 · 1 comment

Comments

@jkasten2
Copy link
Member

Gradle BOM

See Gradle's documentation on what Gradle's bill of materials (BOM) is and what it does.
https://docs.gradle.org/6.5/userguide/platforms.html#sub:bom_import

Requirements

This plugin needs consider any BOM's when picking which versions to enforce.
Today these are ignored which can result in a version being picked which less than the BOM definition.

Example

We should ensure firebase-bom in particular works.
app/build.gradle

dependencies {
    implementation platform('com.google.firebase:firebase-bom:25.3.1')
    // firebase-bom above provides a list of versions,
    //    which is way firebase-messaging does not have a version here
    implementation 'com.google.firebase:firebase-messaging'
}

Related issues

@jkasten2
Copy link
Member Author

This fix for this was much simpler than first expected as the first guess would have been that a Gradle BOM might have been its own entity. However it was a simple skip of null versions which fell back to applying overrides to BOM's constraints which is part of the normal tree.
Fix in #128, part of the now release 0.12.8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant