This repository has been archived by the owner on Oct 31, 2022. It is now read-only.
Adding support for Gradle BOM #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
support_gradle_bom
branch
from
1333ef1
to
6acb2c2
Compare
jkasten2
changed the title
jkasten2
force-pushed
the
support_gradle_bom
branch
from
6acb2c2
to
2e402a5
Compare
mikechoch
reviewed
Jun 15, 2020
| implementation 'com.google.firebase:firebase-common:17.1.0' | ||
|
|
||
| // implementation 'com.google.firebase:firebase-messaging:15.0.2' | ||
| // implementation 'com.google.firebase:firebase-core:16.0.0' |
There was a problem hiding this comment.
Why are there a few commented out lines here? Just curious
There was a problem hiding this comment.
Should compile 'com.android.support:appcompat-v7:26.0.0' be flipped to implementation as well and commented out?
There was a problem hiding this comment.
Didn't mean to commit this, I was just testing. Fixed!
* If a project is using a BOM file (such as firebase-bom) as the only source for a version number on a dependency we were incorrectly downgrading. * This was resloved by ignoring null versions
jkasten2
force-pushed
the
support_gradle_bom
branch
from
2e402a5
to
6056f3e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
See Issue #127 for a summary
Summary of Changes
Since BOM files allow you to omit defining a version at all the requested version is
null. At the apply override step we check the original version which when we seenullwe assumed the version was0. This means we force either an invalid version or downgrade when should not. We now skip by thesenullversions as the BOM inserts a constraint entry which is picked up the sameoverrideVersionflow and can apply it like a normal direct dependency.Useful debugging commit - 1333ef1
It was unneeded but if we ever need to omit BOMs from group alignment calculations see PR #129