Skip to content
This repository has been archived by the owner on Oct 31, 2022. It is now read-only.

Fixed Android Support Library downgrade to invalid "28" version #138

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Fixed Android Support Library downgrade to invalid "28" version #138

merged 2 commits into from
Oct 9, 2020

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 9, 2020 •
edited

  • Added assert for "FAILED" which uncovered the issue by failing the following existing test
    • "Upgrade to compatible OneSignal SDK when targetSdkVersion is 29"
  • cherry-picked commit from Update GradleProjectPlugin.groovy #135 which fixes the issue.

@jkasten2 jkasten2 requested a review from Jeasmine October 9, 2020 06:50
@jkasten2 jkasten2 changed the title Added a generic "FAILED" check to all tests [WIP} Added a generic "FAILED" check to all tests Oct 9, 2020
@jkasten2 jkasten2 changed the title [WIP} Added a generic "FAILED" check to all tests [WIP] Added a generic "FAILED" check to all tests Oct 9, 2020
@jkasten2 jkasten2 removed the request for review from Jeasmine October 9, 2020 06:51
@jkasten2
Added a generic "FAILED" check to all tests
d6a27b1 
* Test now started to fail in this commit which uncoved an issue
   - "Upgrade to compatible OneSignal SDK when targetSdkVersion is 29"
* Fixing this failing test in an up comming commit
@jkasten2 jkasten2 force-pushed the fix/downgrade_to_invalid_28_version_of_android_support_libraries branch from ba954be to d6a27b1 Compare October 9, 2020 06:51
@chancezeus @jkasten2
Update GradleProjectPlugin.groovy
d3f25ac 
Fix maxAndroidSupportVersion returning invalid version string
@jkasten2 jkasten2 changed the title [WIP] Added a generic "FAILED" check to all tests Added a generic "FAILED" check to all tests Oct 9, 2020
@jkasten2 jkasten2 requested a review from Jeasmine October 9, 2020 07:43
@jkasten2 jkasten2 mentioned this pull request Oct 9, 2020
Closed
@jkasten2 jkasten2 changed the title Added a generic "FAILED" check to all tests Fixed Android Support Library downgrade to invalid "28" version Oct 9, 2020
Base automatically changed from tests/clean/assert_results_helper to master October 9, 2020 20:35
@jkasten2 jkasten2 merged commit 39b91b2 into master Oct 9, 2020
@jkasten2 jkasten2 deleted the fix/downgrade_to_invalid_28_version_of_android_support_libraries branch October 9, 2020 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jeasmine Jeasmine Jeasmine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkasten2 @Jeasmine @chancezeus