This repository has been archived by the owner on Oct 31, 2022. It is now read-only.
AGP detection with Version.ANDROID_GRADLE_PLUGIN_VERSION #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated asset to latest version so tests pass
* `./gradlew wrapper --gradle-version=6.6.1 --distribution-type all` * Updates to gradle-wrapper.jar and gradlew were intended as they were part of the Gradle update
* com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION is a more reliable way to detect the AGP version. * Still using reading the jar's META-INF/MANIFEST.MF as a fallback * Lastly a new 3rd fallback to go off the Gradle version - APG version from this just a likely assumption
jkasten2
force-pushed
the
fix/agp_version_detection
branch
from
15bb45f
to
c2ea569
Compare
jkasten2
changed the base branch from
master
to
upgrade/apg_4.1.1_and_gradle_6.7.1
Jeasmine
approved these changes
Dec 7, 2020
jkasten2
force-pushed
the
upgrade/apg_4.1.1_and_gradle_6.7.1
branch
from
fe5ae07
to
f66dd37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The follow error prints for some Android projects when it should not.
This was more common but didn't happen for all Cordova projects. See issues below:
https://github.com/OneSignal/OneSignal-Cordova-SDK/search?q=com.android.tools.build%3Agradle%3A3.0.0&type=issues
This wrong version detection was resulting in not only displaying this incorrect warning however setting
gradleV2PostAGPApplyFallback = truewhich is an internal flag used from some fallback logic they may cause issues version rules not applying and resulting in not solving some mismatches as this plugin should.Changes
com.android.Version.ANDROID_GRADLE_PLUGIN_VERSIONis a more reliable way to detect the AGP version.NOTE: Change base to
masterafterupgrade/apg_4.1.1_and_gradle_6.7.1is merged