This repository has been archived by the owner on Oct 31, 2022. It is now read-only.
Fix disableVersionCheck when GoogleServicesPlugin is applied with afterEvaluate #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
upgrade/apg_4.1.1_and_gradle_6.7.1
branch
from
fe5ae07
to
f66dd37
Compare
jkasten2
force-pushed
the
fix/disableGMSVersionChecks
branch
from
0a1219c
to
a7a7401
Compare
jkasten2
changed the title
* This covers the disableVersionCheck feature we never had test coverage on before.
jkasten2
force-pushed
the
fix/disableGMSVersionChecks
branch
from
a7a7401
to
e17df79
Compare
* Adding a failing test where our disableVersionCheck does not work if the google-services gradle plugin was added with afterEvaluate
* The issue was there is a race condition with the project's `afterEvaluate` and this plugin. The order operations was a follows: 1. This plugin's afterEvaluate fires 2. `googleServices` is not found 3. Project's afterEvaluate fires 4. Project run's apply plugin: 'com.google.gms.google-services' 5. We never set `disableVersionCheck = true` * To fix the issue switched to `project.plugins.withType(Plugin)` which fires as soon as a plugin is applied, no matter how / when it was.
jkasten2
changed the title
|
✔️ Test passed "Travis CI - Pull Request Successful in 10m — Build Passed" Ignore failed "Travis CI - Branch Cancelled after 5m — Build Canceled" as I did cancel it on purpose as tests were running twice. |
rgomezp
approved these changes
Dec 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
disableGMSVersionChecksdoesn't work in a case which this PR addresses.Fixes
Reviewing
Recommend reviewing commit by commit