This repository has been archived by the owner on Oct 31, 2022. It is now read-only.
Set jvm version for compileGroovy #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Groovy does not automatically use the compileJava settings so we need to define compileGroovy. * Also defining as Java 1.8 so when a project consuming this plugin it can run it with getting a "class file version" error.
Jeasmine
approved these changes
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to define compileGroovy.
it can run it with getting a "class file version" error.
This will fix errors such as
Tests
Manual
Ran
./gradle buildon an Android project with a local build of this plugin with Java 8 to reproduce the issue. Then rebuilt with this new setting to ensure this resolved the issue.This change is