[Fix] ANRs for callbacks and when backgrounding app #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix rare Android ANRs when OneSignal callbacks fire and when the app is backgrounded.
Details
Motivation
The time spent on the main thread in this scenario is significantly contributing to ANRs. The Google Play store penalizes apps with ANRs with lower search rankings and possibly some other negatives.
Scope
Only effects Android and threading used for callbacks, observers, and events like click.
Dependent OneSignal-Android-SDK PRs
These are the two PRs that were included in the OneSignal-Android-SDK 4.8.6 release this PR depends on:
Testing
Unit testing
None
Manual testing
Tested on Samsung S21 with Android 13. Ensured
SetExternalUserId
's callback still fires in the example app here.Also ensured the threading preference value did change by printing its value back in C#.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)