Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Migration guide table format #724

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[Fix] Migration guide table format #724

merged 1 commit into from
Apr 16, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Apr 16, 2024

Description

One Line Summary

Fixes the table format in the v3 to v5 migration guide for User Namespace.

Details

Motivation

Fixes typo in the table formatting of the Unity migration guide for the "changed" user event.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l requested a review from emawby April 16, 2024 19:37
@shepherd-l shepherd-l assigned shepherd-l and emawby and unassigned shepherd-l Apr 16, 2024
@shepherd-l shepherd-l merged commit cfe014e into main Apr 16, 2024
1 check passed
@shepherd-l shepherd-l deleted the fix/migrationGuide branch April 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants