Don't default to document title if no notification title present #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't default to document title if no notification title present
Detailed description
Notification titles used to be required in browsers. We allowed users to not provide a title, but if that happened, we defaulted to the document.title property. This is no longer a required field for notifications, and browsers handle it differently (i.e. Chrome says 'Google Chrome' if no title is present).
This continues to use the default title value if it is provided by the user by calling
OneSignal.setDefaultTitle
.Checklist:
Jira Ticket(s):
OS-4666
Screenshots/Gifs/Video of All Changes:
With no title or default title set:
Default title set, then with an actual notification title:
Users Affected:
Estimated number of users this change will impact:
All end users who receive notifications without a set title
Validation:
OneSignal.setDefaultTitle(<string>)
)This change is