Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM CookieSyncer #701

Merged
merged 2 commits into from
Sep 17, 2020
Merged

RM CookieSyncer #701

merged 2 commits into from
Sep 17, 2020

Conversation

jmadler
Copy link
Contributor

@jmadler jmadler commented Sep 17, 2020 •
edited by sync-by-unito bot

Remove the CookieSyncer class, which loads the no-longer-necessary webAnalytics iframe.

This change is Reviewable

@jmadler jmadler mentioned this pull request Sep 17, 2020
Closed
3 tasks
jkasten2
jkasten2 requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some entries should be cleaned up in test/support/tester/utils.ts

https://github.com/OneSignal/OneSignal-Website-SDK/search?q=webPushAnalytics&unscoped_q=webPushAnalytics

Everything else looks good!

jkasten2
jkasten2 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test clean up! LGTM

@jmadler jmadler merged commit 60e5a61 into master Sep 17, 2020
@jmadler jmadler deleted the rm-cookiesync branch September 17, 2020 21:40
@jmadler jmadler mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

@itrush itrush Awaiting requested review from itrush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmadler @jkasten2