Recover from wiped IndexedDB if push signal is sent #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has their IndexedDB wiped, but the service worker is still active, on Chrome and Firefox we will recover the user's ID based on the subscription endpoint from OneSignal's server and retry receiving the notification. If the recovery attempt fails, the user is unsubscribed from push notifications so that he does not receive "New site updates" messages.
jasonpang
force-pushed
the
amend-missing-userid
branch
from
94a27fa
to
3555ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has their IndexedDB wiped, but the service worker is still
active, on Chrome and Firefox we will recover the user's ID based on the
subscription endpoint from OneSignal's server and retry receiving the
notification. If the recovery attempt fails, the user is unsubscribed
from push notifications so that he does not receive "New site updates"
messages.
This change is