Http modal prompt #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 7, 2016 17:14
Save commit before tearing out block state on HTTP popover.
The methods waitUntilShown() and waitUntilHidden() were not working correctly for the notify button after we switched over to using events from EventEmitter. These methods have now been updated and hopefully this fixes the black circle on the notify button some users see sometimes. Updated popover show condition to not show if the autoRegister is false.
- Increased popup window dimensions by 100 pixels each - Fixed bug with notify button showing black small circle badge - Consolidate mobile and desktop prompt options
- Pass parent HTTP site hostname so that if a user does not configure siteName, a reasonable default is shown "e.g. google.com" - Truncate customization values for HTTP prompt and popup - Site name is at most 30 characters long - Action message is at most 90 characters long - Buttons are at most 15 characters long - Do not allow prompt to be shown twice - Share prompt customization values from HTTP popup's promptOptions variable - Rename public API from showHttpPopover() -> showHttpPrompt() - showHttpPrompt() resolves to brief string reasons if prompt was not shown - Fix multiple showings of showHttpPrompt() opening multiple windows by listening to event handlers once
iFrame, popup, and modal routes have been shortened from 'initOneSignalHttp' to '/subscribe', '/webPushIframe', and '/webPushModal'. The HTTP popup is also now loaded via a POST call instead of a GET call which allows hiding the long URL query parameters and presents the user which a much simpler URL of "https://subdomain.onesignal.com/subscribe". The routes in the Rails backend and the web SDK have been modified to accomodate these shorter routes.
jasonpang
force-pushed
the
http-modal-prompt
branch
from
38c81ab
to
16ec192
Compare
added 2 commits
July 7, 2016 18:43
HTTP popup autoAccept was broken because the data wasn't being POSTed. Fixed and refactored the helper methods getPromptOptionsQueryString to use getPromptOptionsQueryHash.
And remove comment
jasonpang
force-pushed
the
http-modal-prompt
branch
from
ceec3c1
to
43abe3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds an HTTP prompt, redesigns the HTTP modal prompt, shortens the routes for the popup, iFrame, and modal.
This change is