[Fix] iOS builds on Windows with projects located at normal or long path lengths

[jkasten2]

Description

One Line Summary

Resolve most iOS builds failing on Windows due Windows due 260 character file path limits.

Details

Motivation

It is common for Xamarin developers to use a Windows machine and a remote macOS machine to build. Builds were failing unless your project's root was an uncommonly short absolute path.

Scope

Only effects iOS builds, only the linking part to .xcframeworks.

Changes made

• Instead of copying the .framework files into the project from the nuget cache via the .targets MSBuild task instead directly reference them.
• Renamed Binding Resource files in .target and .nuspec files from content\OneSignalSDK.Xamarin.iOS.resources to res\iOS to shorten the absolute file paths

Example of error this addresses

Error		Unable to copy file "C:\Users\Kasten\.nuget\packages\onesignalsdk.xamarin\4.1.0\build\Xamarin.iOS\..\..\content\OneSignalSDK.Xamarin.iOS.resources\OneSignal.xcframework\ios-arm64_armv7_armv7s\OneSignal.framework\Headers\OneSignal.h" to "C:\Users\Kasten\source\repos\XamarinFormsTest2OneSignal4_1_0\XamarinFormsTest2OneSignal4_1_0\XamarinFormsTest2OneSignal4_1_0.iOS\bin\iPhone\Debug\/OneSignalSDK.Xamarin.iOS.resources/OneSignal.xcframework\ios-arm64_armv7_armv7s\OneSignal.framework\Headers\OneSignal.h". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.	XamarinFormsTest2OneSignal4_1_0.iOS	C:\Users\Kasten\.nuget\packages\onesignalsdk.xamarin\4.1.0\build\Xamarin.iOS\OneSignalSDK.Xamarin.targets	6	

Issues this resolves

• Fixes Unable to upgrade 4.1.0 however 4.0.0 works fine #312
• Fixes [iOS] Migrating to 4.1.0 throws copy error with Headers (.h) #316
• Fixes [iOS][4.1.0] Unable to compile / OneSignalTrackFirebaseAnalytics.h not found #319

Testing

Manual testing

Window - remote mac build

• Windows 11 Pro 21H2
• Visual Studio 2022 Version 17.2.5
• Remote mac on macOS 12.3.1
• Xamarin.iOS 15.10.0.5
• Xamarin.Forms project
• Tested on both a real device and a simulator and ensured the OneSignal SDK prompts for notifications.

Mac

• MacOS 12.4
• Visual Studio 2022 Version 17.05
• .Net 6.0.0.262
• Xamarin.iOS 15.10.0.5
• Xamarin.Forms project
• Tested on both a real device and a simulator and ensured the OneSignal SDK prompts for notifications.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

---

This change is 

[tanaynigam]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jkasten2)

[jkasten2]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @tanaynigam)

---

OneSignalSDK.Xamarin.nuspec line 4 at r2 (raw file):

<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
    <metadata>
        <version>4.1.5</version>

Version should not be changed in this PR.

[jkasten2]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @tanaynigam)

---

OneSignalSDK.Xamarin.nuspec line 4 at r2 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Version should not be changed in this PR.

Last commit didn't revert this. Looks like, commit d0c0f01 reverted all the other nuspec changes instead.

[jkasten2]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jkasten2)