Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Set External User Id on iOS #318

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

tanaynigam
Copy link
Contributor

@tanaynigam tanaynigam commented Jul 8, 2022

Description

One Line Summary

Fix Set External User Id not working on iOS

Details

Motivation

Temporary fix to set external user id not working on iOS. The previous implementation uses a single SetExternalUserId method with optional nullable parameter hashToken in Xamarin. However, OneSignal iOS native SDK does not support nullable hashToken as a parameter. This fix uses temporary function overloading to allow users to continue using SetExternalUserId without a hashToken

Scope

  • Added SetExternalUserId method without hashToken parameter to iOS, Android and Core projects

Issues this resolves

Testing

Manual testing

  • MacOS 12.4
  • Visual Studio 2022 Version 17.05
  • .Net 6.0.0.262
  • Xamarin.iOS 15.10.0.5
  • Xamarin.Forms project
  • Created and tested a nuget package on an iOS device

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* Add a temporary setExternalUserId method without hash token
@tanaynigam tanaynigam requested a review from jkasten2 July 8, 2022 23:04
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tanaynigam)

@tanaynigam tanaynigam merged commit d41332c into main Jul 12, 2022
@tanaynigam tanaynigam deleted the set_external_user_id_fix branch July 12, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneSignal.Default.SetExternalUserId value cannot be null - Parameter name hashtoken
2 participants