Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix Set External User Id not working on iOS
Details
Motivation
Temporary fix to set external user id not working on iOS. The previous implementation uses a single
SetExternalUserId
method with optional nullable parameterhashToken
in Xamarin. However, OneSignal iOS native SDK does not support nullablehashToken
as a parameter. This fix uses temporary function overloading to allow users to continue usingSetExternalUserId
without ahashToken
Scope
SetExternalUserId
method withouthashToken
parameter to iOS, Android and Core projectsIssues this resolves
Testing
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is