[Add] Android 13 notification permission prompting #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required so the new promptForPushNotifications becomes available for android.
PromptForPushNotificationsWithUserResponse already exists as a public method for iOS, this comment simply adds the required code to connect this feature to the OneSignal-Android-SDK.
Also add some output so the accept or decline value can be seen in the log.
Added this option to both iOS and Android. The OneSignal-iOS-SDK already had this feature but it was connected before.
Merged
nan-li
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds notification permission prompting for Android 13 devices.
Details
Motivation
Android 13 requires prompting for permission before notifications can be displayed.
Scope
Pre-existing
OneSignal.PromptForPushNotificationsWithUserResponsemethod has the following changes:fallbackToSettingsoption.Related PRs
This feature was added in the OneSignal-Android-SDK PRs OneSignal/OneSignal-Android-SDK#1607 and OneSignal/OneSignal-Android-SDK#1615.
Testing
Unit testing
None, no pre-existing infrastructure.
Manual testing
Tested with Visual Studio for Mac 2019 on the included Sample project. Tested with an Android 13 beta 3 emulator and an iOS Simulator on iOS 15.4.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is