Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x.x] Update privacy manifests and add 2 more #1392

Merged
merged 3 commits into from Mar 25, 2024

Commits on Mar 22, 2024

  1. Add target membership for the Privacy Manifests

    * Added the 2 existing Privacy Manifests to targets `OneSignalFramework` and `OneSignalExtension`
    * This is needed for SDK consumers to get the privacy manifests included in their report.
    nan-li committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2f69dfb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Add manifests for Outcomes + Core

    * Apple docs has called out all 4 player model modules in their "SDKs that require a privacy manifest and signature" (https://developer.apple.com/support/third-party-SDK-requirements/)
    - OneSignal
    - OneSignalCore
    - OneSignalExtension
    - OneSignalOutcomes
    
    * Since we are making a change to the other 2 existing manifest files, let's add manifest files for all the frameworks in case we may be required to update the player model SDK again due to them missing from Core and Outcomes
    nan-li committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    674800e View commit details
    Browse the repository at this point in the history
  2. add NSPrivacyCollectedDataTypes to Core

    * Apparently `NSPrivacyCollectedDataTypes` needs to be in the privacy manifest for Core even though the framework doesn't use any.
    * The generated report would say "Missing an expected key: 'NSPrivacyCollectedDataTypes' YourApp.app/Frameworks/OneSignalCore.framework/PrivacyInfo.xcprivacy"
    nan-li committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1349904 View commit details
    Browse the repository at this point in the history