Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy manifests - User Defaults API reason to include app groups #1429

Merged
merged 1 commit into from
May 10, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented May 7, 2024

Description

One Line Summary

Update Privacy Manifest for Extension and OneSignal usage of User Defaults API reason to include app groups, extensions, and app clips.

Details

Previously:
CA92.1 - Declare this reason to access user defaults to read and write information that is only accessible to the app itself.

Now:
1C8F.1 - Declare this reason to access user defaults to read and write information that is only accessible to the apps, app extensions, and App Clips that are members of the same App Group as the app itself.

SDK clients are instructed to set up app groups is so that some data can be shared in the Notification Service Extension and the main app target.

Motivation

Scope

Privacy manifests

Testing

Unit testing

None

Manual testing

None

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes - Sort Of

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li changed the title Privacy manifests update User Defaults API reason to include app groups, extensions, clips Privacy manifests - User Defaults API reason to include app groups, extensions, clips May 8, 2024
@nan-li nan-li changed the title Privacy manifests - User Defaults API reason to include app groups, extensions, clips Privacy manifests - User Defaults API reason to include app groups May 8, 2024
@nan-li nan-li requested a review from emawby May 8, 2024 02:02
…ps, extensions, clips

Previously:
CA92.1 - Declare this reason to access user defaults to read and write information that is only accessible to the app itself.

Now:
1C8F.1 - Declare this reason to access user defaults to read and write information that is only accessible to the apps, app extensions, and App Clips that are members of the same App Group as the app itself.
@nan-li nan-li force-pushed the privacy_manifests_user_defaults branch from 19de331 to df57c57 Compare May 10, 2024 18:45
@nan-li nan-li merged commit 8c70169 into main May 10, 2024
3 of 4 checks passed
@nan-li nan-li deleted the privacy_manifests_user_defaults branch May 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants