Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional 6 privacy manifests to the 6 sub-targets #1431

Merged
merged 2 commits into from
May 10, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented May 10, 2024

Description

One Line Summary

Add additional privacy manifests to User, Notifications, LiveActivities, Outcomes, OSCore, and Core by following Apple documentation.

Details

In #1334 we added Privacy Manifest to the 4 targets that clients would import.

There was this comment in the PR:

Currently, they are not added to the other targets such as Core, Outcomes, User, etc. as these targets are already accounted for by inclusion in the umbrella OneSignalFramework target. App developers do not import these smaller modules directly but only via OneSignalFramework.

We will await feedback if the above is true and these "sub-modules" don't need a privacy manifest.

We haven't received concrete information on the last question, but since that PR, Apple has released a list of SDKs that require a privacy manifest and signature and listed the following player model SDKs, leading me to believe they do detect every sub target?

  • OneSignal
  • OneSignalCore
  • OneSignalExtension
  • OneSignalOutcomes

Motivation

Third-party privacy manifests required by Apple.

Scope

Privacy Manifests

Testing

Unit testing

None

Manual testing

Build and archive app, inspect the Privacy Report
See the generated report for the example app OneSignalExample-PrivacyReport.pdf

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* In each of the following targets that aren't imported on their own but are included in the primary targets.
* For completeness, we also provide a privacy manifest for each of these.
- OneSignalUser
- OneSignalNotifications
- OneSignalLiveActivities
- OneSignalOutcomes
- OneSignalOSCore
- OneSignalCore
@nan-li nan-li force-pushed the add_privacy_manifests_to_all_targets branch from 6886b02 to 1c5d7e8 Compare May 10, 2024 19:25
@nan-li nan-li changed the base branch from main to privacy_manifests_user_defaults May 10, 2024 19:31
@nan-li nan-li requested a review from emawby May 10, 2024 19:32
Base automatically changed from privacy_manifests_user_defaults to main May 10, 2024 20:45
@nan-li nan-li merged commit 27e3d36 into main May 10, 2024
3 of 4 checks passed
@nan-li nan-li deleted the add_privacy_manifests_to_all_targets branch May 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants