Fix prompting for location permission #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Apr 3, 2019
|
@troy-lamerton Thanks for digging in and making this PR! I left some comments about if these are the correct |
jkasten2
approved these changes
Apr 4, 2019
|
I confirmed this fixes the issue of prompting for background location if only the foreground position is accepted when the app is cold started the next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed use of the prompt boolean.
If the authorization status of location permission is 'when in use' then the always allow prompt was being shown by one signal - even when the prompt parameter is false.
This PR enforces the correct conditions to request location permission.
This change is