-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API URL to circumvent block in Egypt #595
Conversation
It appears that subdomains of onesignal.com are not blocked by the Egyptian ISP TE Data (also known as WE) Fixes OneSignal#554 & OneSignal#545
@iSWORD Are you still experiencing OneSignal being blocked in Egypt? This should be fixed already, no need to modify the URL this would only be a temporary fix any way. |
Well sadly we can't merge a PR if this is simply a temporary fix, but you should not be experiencing any blocking so we will investigate this. Are you using any apps that might have a blacklist to block specific URLs? We had one customer with a rooted Android device that had an ad blocker with root privileges. This ended being the cause of onesignal.com being blocked. |
It doesn't work on any of my devices. This fix might be temporary in a way that Egypt may block subdomains of OneSignal.com at some point, but it's not something that will break any functionality for other people, so merging it shouldn't be a problem. |
I understand, but we will not be changing the URL we use in our SDK. This should remain the same and we will look into getting Egypt up and running again if it is truly blocked. I will be closing this PR now. |
That's a bummer. I don't see how changing the URL to a first party alias could cause any problems but you're the maintainer so what do I know. I have no other choice but to use SNS to meet our SLAs though because my clients will ask for an action plan with a clear timeline. Thank you & good luck getting TE Data to unblock your domain :) |
Moving to Firebase directly or Amazon SNS like @iSWORD mentioned is the best solution for a problem exists since August 2019 and only been noticeable in October 2019. adding an argument to OneSignal init function to change base_url seem to be something you won't even wanna think about it. |
@mikechoch We can understand the size and impact proposed here along with the affected users. We can check possible solutions like passing variables while installing the plugin with default settings to be the current one. maybe pass one of predefined list while installing to ensure more secure approach avoiding random URLs (ex. --USE_APP_SUBDOMAIN="true") |
The change to use https://github.com/OneSignal/OneSignal-iOS-SDK/releases/tag/2.13.0 |
this is great news. |
It appears that subdomains of onesignal.com are not blocked by the Egyptian ISP TE Data (also known as WE)
Fixes #554 & #545
This change is