Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timezone id to user data #866

Merged
merged 6 commits into from Feb 19, 2021
Merged

Added timezone id to user data #866

merged 6 commits into from Feb 19, 2021

Conversation

gonzalonarbaiz
Copy link
Contributor

@gonzalonarbaiz gonzalonarbaiz commented Feb 2, 2021

Added timezone_id to user data to be sent.

This change is Reviewable

Copy link
Contributor

@Jeasmine Jeasmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need a test as on Android

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs a test added
  • Needs a rebase as there is a mere conflict

@gonzalonarbaiz gonzalonarbaiz merged commit ee389b9 into master Feb 19, 2021
@gonzalonarbaiz gonzalonarbaiz deleted the fix/timezone_bug branch February 19, 2021 18:31
@jkasten2 jkasten2 mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants