Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta testing of the new 2.0.0 release #103

Closed
avishayil opened this issue Nov 3, 2016 · 11 comments
Closed

Beta testing of the new 2.0.0 release #103

avishayil opened this issue Nov 3, 2016 · 11 comments

Comments

@avishayil
Copy link
Contributor

avishayil commented Nov 3, 2016

Hello everyone,
We need your help here to test the new release.
You can try it all right now by changing your package.json dependency to the following:

"react-native-onesignal": "git://github.com/geektimecoil/react-native-onesignal.git#dev"

No changes needed on the native side, just make sure you're updating the OneSignal Pod to the latest one, and on the Javascript side your'e using the new variables.

Please discuss any issues your'e encountering in this thread until the official release.

Current issues:

  1. inFocusDisplaying method might not be working on Android.
@jkasten2
Copy link
Member

jkasten2 commented Nov 4, 2016

@avishayil I haven't been able to reproduce an issue with inFocusDisplaying. I see both required pieces are in the dev branch.
RNOneSignal.java
index.js

Can you attach the fullstack trace with line numbers if you are still seeing an issue?

@iamhainguyen
Copy link

I updated both the Pod and the module as suggested. However xcode showed me lots of errors:
screen shot 2016-11-04 at 3 29 21 am

Commented them out let me run the app in ios normally. However, the rich notifications (ones with videos/ images) didn't work. Is rich notification supported in this dev build or still not ready yet?

Thanks.

@jkasten2
Copy link
Member

jkasten2 commented Nov 4, 2016

@hnguyen87 It looks like your using a 2.0 version of the OneSignal.framework but it isn't the newest 2.2.0. Can you make sure the method you used to get it gave you the most up to date version. Example you can run the following to update if you are using cocoapods.

pod update OneSignal

You can contact OneSignal support listing your app_id and linking them this thread and we take a look at your account to confirm the version number.

@avishayil
Copy link
Contributor Author

@jkasten2 I've tested the most basic functionality of the iOS library and it works as expected (received, opened, idsAvailable, getTags, setTags).
I still need some testing for the p2p notifications and the rest of the functions, would love some help on this.

I still haven't figured out how to deal with the Android issue I have, can we schedule maybe a debugging session on TeamViewer?

@iamhainguyen
Copy link

@jkasten2 the dev works for me now. However it looks like the Rich Notification on iOS doesn't work. Would you please confirm it for me? Thanks very much for your hard work!

@jkasten2
Copy link
Member

@hnguyen87 iOS 10 have some additional requirements, see our Notifications with action buttons or iOS 10 media not displaying troubleshooting guide to make sure everything is enabled.

@iamhainguyen
Copy link

@jkasten2 thanks very much for your help. However it just works for me with images, doesn't work with video or gif. Do you know what may cause it? Thanks

@jkasten2
Copy link
Member

@hnguyen87 Make sure you URL's end with a file extension so the SDK can tell what type of file it is.
If this isn't the issue can you share the git/video URLs you are trying?

@afdalwahyu
Copy link

does it works with react-native link command?
btw can i change onesignal_app_id & onesignal_google_project_number in .js file?

@avishayil
Copy link
Contributor Author

avishayil commented Nov 26, 2016 via email

@logileifs
Copy link

Where can I find documentation on how to use the new ios rich notifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants