Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example AwesomeProject from npm package #25

Closed
badnorseman opened this issue Apr 27, 2016 · 1 comment
Closed

Remove example AwesomeProject from npm package #25

badnorseman opened this issue Apr 27, 2016 · 1 comment

Comments

@badnorseman
Copy link

Thank you for providing a really easy way to use OneSignal notifications with React Native.

Please would it be possible to exclude the example AwesomeProject from the npm package.

When I use cloud services for continuous integration, I have observed that pod file in the example messes up the build. Also, it would be better, if the npm package only includes whatever is required to integrate and run with own project.

@avishayil
Copy link
Contributor

That's a good idea, I'll add it to the TODO list.
Thanks.
On Apr 27, 2016 23:22, "Dan Jensen" notifications@github.com wrote:

Thank you for providing a really easy way to use OneSignal notifications
with React Native.

Please would it be possible to exclude the example AwesomeProject from the
npm package.

When I use cloud services for continuous integration, I have observed that
pod file in the example messes up the build. Also, it would be better, if
the npm package only includes whatever is required to integrate and run
with own project.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants