iOS native has not yet released, but this is a fix for after 3.9.0 #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix is related to the `NSDictionary` param keys not matching Android * This is consistent now and determined not from the bridge method but the actual native code * `[action jsonRepresentation]` will be used to generate the `NSDictionary` and will be passed to react that way * This should also be done across other wrappers no already doing this and it fixes the react native issue #1012
mikechoch
changed the title
Jeasmine
approved these changes
Aug 11, 2020
Jeasmine
reviewed
Aug 11, 2020
jkasten2
approved these changes
Aug 14, 2020
|
@Jeasmine Travis is failing on master on this repo as well, it hasn't been correctly setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSDictionaryparam keys not matching Android[action jsonRepresentation]will be used to generate theNSDictionaryand will be passed to react that wayLinked to this native iOS PR
OneSignal/OneSignal-iOS-SDK#704