Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering for push notifications at a later time #13

Merged
merged 2 commits into from
Apr 24, 2016
Merged

Registering for push notifications at a later time #13

merged 2 commits into from
Apr 24, 2016

Conversation

micksabox
Copy link
Contributor

I've added the ability to register for push notifications at a later time. It is sometimes advantageous for the app to ask for push permissions in the context of some action or behaviour. For example, subscribing to a topic. This could mean increased push registration rates, and a better user experience than simply asking for push permissions on app first launch.

@avishayil
Copy link
Contributor

Thanks @micksabox , i'll test it :>

@weixiyen
Copy link

@avishayil have you been able to test & confirm? This feels like a must-have feature.

Also thanks for this library.

@avishayil
Copy link
Contributor

Hi, @micksabox I didn't have the time to do this yet, i'm aiming for Thursday to free some time to do it.

@ghost ghost mentioned this pull request Apr 14, 2016
@p-janik
Copy link

p-janik commented Apr 15, 2016

What about this PR? Wanted to create similar PR.

@avishayil avishayil merged commit 369426c into OneSignal:master Apr 24, 2016
@JonathanWi
Copy link

This method only works for iOS right @micksabox ?

@micksabox
Copy link
Contributor Author

Yes, just on iOS. I am not familiar with how this would work on Android.

On May 4, 2016, at 6:11 AM, Jonathan Widawski notifications@github.com wrote:

This method only works for iOS right @micksabox https://github.com/micksabox ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #13 (comment)

@maxs15 maxs15 mentioned this pull request Jun 7, 2016
@whollacsek
Copy link

@micksabox Could you please add a usage example in the README? The permission alert keeps showing up on launch.

@felixaa
Copy link

felixaa commented Jul 4, 2016

+1 on usage example. Permission alert keeps showing up on launch

@avishayil
Copy link
Contributor

NP, Will be added soon.

@felixaa
Copy link

felixaa commented Jul 4, 2016

Thanks alot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants