Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent init onHostResume if already initialized for that activity context #1553

Closed
wants to merge 2 commits into from

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Sep 7, 2023

Description

One Line Summary

Prevent init onHostResume if already initialized for that activity context

Details

Previously we were entering into the init function and logging the error "Already initialized..." which was reported as a bug.

Motivation

Fixes: #1521

Testing

Manual testing

TO DO: haven't tested

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

…ntext

Previously we were entering into the init function and logging the error "Already initialized..." which was reported as a bug.
@rgomezp rgomezp closed this Sep 7, 2023
@rgomezp rgomezp deleted the update-bridge-init-logic branch September 8, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Already initialized the OneSignal React-Native SDK
1 participant