[5.0.0] Fix permission listener, export a few more types #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer used
* Export: - `PushSubscriptionState` - `PushSubscriptionChangedState` - `InAppMessageClickResult`
The bridge passes a dictionary, not a single boolean. We need to extract the boolean to pass to permission listeners.
jkasten2
approved these changes
Sep 14, 2023
nan-li
force-pushed
the
post_5.0.0_fixes_branch
branch
from
3bbf06b
to
9069cb8
Compare
emawby
approved these changes
Sep 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
A few fixes post 5.0.0-release, includes 1 bug fix.
Details
Motivation
A few fixes post 5.0.0-release, includes 1 bug fix.
1. Remove OutcomeEvent as no longer used
2. Export a few more types through index file
PushSubscriptionStatePushSubscriptionChangedStateInAppMessageClickResult3. Add the SDK wrapper type
4. Fix permission boolean
The bridge passes a dictionary, not a single boolean. We need to extract the boolean to pass to permission listeners.
Testing
Manual testing
Test on Android emulator 33 and iPhone 13
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is