Initialization Race Condition Fix #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Fixes an issue where the OneSignal iOS native SDK was being initialized too early in the iOS application lifecycle, causing a race condition. • This race condition, in some cases, would cause an issue where users would not get subscribed to OneSignal, they'd have a null push token/userId, could not receive notifications, etc. • Fixed by swizzling UIApplication.didFinishLaunchingWithOptions. This swizzled method gets called before the AppDelegate's own implementation of this method, and this lets the SDK ensure that the OneSignal iOS sdk is initialized. This is how Onesignal's Cordova SDK (as well as others) perform initialization. • Removed some unnecessary header files
This was referenced May 17, 2018
jkasten2
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixes an issue where the OneSignal iOS native SDK was being initialized too early in the iOS application lifecycle, causing a race condition.
• This race condition, in some cases, would cause an issue where users would not get subscribed to OneSignal, they'd have a null push token/userId, could not receive notifications, etc.
• Fixed by swizzling UIApplication.didFinishLaunchingWithOptions. This swizzled method gets called before the AppDelegate's own implementation of this method, and this lets the SDK ensure that the OneSignal iOS sdk is initialized. This is how Onesignal's Cordova SDK (as well as others) perform initialization.
• Removed some unnecessary header files