Fix Bridge Reload Issue #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• When react-native apps get reloaded, the existing bridge is destroyed and a new bridge is created. • Our SDK was not properly registering the new bridge to receive onReceived and onOpened events for notifications • Changes the 'registeredEvents' boolean to be an instance variable instead of a static variable. • Also adds code to remove event listeners when the bridge gets destroyed.
jkasten2
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• When react-native apps get reloaded, the existing bridge is destroyed and a new bridge is created.
• Our SDK was not properly registering the new bridge to receive onReceived and onOpened events for notifications
• Changes the 'registeredEvents' boolean to be an instance variable instead of a static variable.
• Also adds code to remove event listeners when the bridge gets destroyed.