Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary rnpm config (fix for RN@v0.60.0) #794

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Remove unnecessary rnpm config (fix for RN@v0.60.0) #794

merged 1 commit into from
Jul 15, 2019

Conversation

yenbekbay
Copy link
Contributor

"rnpm" was deprecated in React Native 0.60.0. Furthermore, even though it's still supported in legacy mode, apparently the config used in this library is invalid:

Screen Shot 2019-07-06 at 21 36 11

@yenbekbay yenbekbay changed the title Remove unnecessary config (fix for RN@v0.60.0) Remove unnecessary rnpm config (fix for RN@v0.60.0) Jul 6, 2019
@jkasten2
Copy link
Member

@yenbekbay Thanks for the PR. It looks like this fixes the Unknown option dependency.platforms.ios.sourceDir with value ""./ios"" was found. error noted in #792

@jkasten2 jkasten2 merged commit ec5035d into OneSignal:master Jul 15, 2019
@yenbekbay yenbekbay deleted the fix/remove-rnpm branch July 19, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants