Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a min React version of 0.13.0 for iOS #803

Merged
merged 1 commit into from Jul 15, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 11 additions & 4 deletions react-native-onesignal.podspec
Expand Up @@ -2,7 +2,6 @@ require 'json'
package_json = JSON.parse(File.read('package.json'))

Pod::Spec.new do |s|

s.name = "react-native-onesignal"
s.version = package_json["version"]
s.summary = package_json["description"]
Expand All @@ -12,8 +11,16 @@ Pod::Spec.new do |s|
s.platform = :ios, "7.0"
s.source = { :git => "#{package_json["repository"]["url"]}.git", :tag => "#{s.version}" }
s.source_files = 'ios/RCTOneSignal/*.{h,m}'

# The "React" pod is required due to the use of RCTBridgeModule, RCTEventEmitter, etc
# Ensuring we have version 0.13.0 or greater to avoid a cocoapods issue noted in React Native's release notes
# https://github.com/facebook/react-native/releases/tag/v0.13.0
# The last stable version on Cocapod's repo is 0.11.0 as we want to ignore it to always use the local copy.
s.dependency 'React', '>= 0.13.0', '< 1.0.0'

s.dependency 'React'
s.dependency 'OneSignal', '2.10.0'
# REQUIRED: Ensure you have the following in your project's Podfile
# pod 'React', :path => '../node_modules/react-native/'

end
# The Native OneSignal-iOS-SDK from cocoapods.
s.dependency 'OneSignal', '2.10.0'
end