views/life_MD: Disable tours in museum display #810 #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tours contain media copyright links we can't remove, and once followed you're outside the onezoom sandbox. We either need to pop-up-ize them like we do with wikipedia, or pull an attribution line in javascript. Either is relatively fiddly. Disable tours for now. NB: the tours tab is already disabled, so we just have to hide the controls at the side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tours contain media copyright links we can't remove, and once followed you're outside the onezoom sandbox.
We either need to pop-up-ize them like we do with wikipedia, or pull an attribution line in javascript. Either is relatively fiddly.
Disable tours for now. NB: the tours tab is already disabled, so we just have to hide the controls at the side.