Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev user op set default is_dynamic #5223

Merged
merged 7 commits into from Jun 17, 2021

Conversation

ShawnXuan
Copy link
Contributor

@ShawnXuan ShawnXuan commented Jun 17, 2021

fix reshape is_dynamic bug in oneflow_wdl.
bug原因:
user op的out tensor_desc的默认值是第一个输入tensor的tensor_desc,但是实际上is_dynamic的推导应该是只要有一个输入是dynamic,out就应该默认是dynamic的

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@ShawnXuan ShawnXuan added the ci label Jun 17, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 17, 2021 05:59
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 17, 2021 05:59
@guo-ran guo-ran requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 17, 2021 06:18
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 17, 2021 07:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 17, 2021 08:36
@liujuncheng liujuncheng merged commit ce3f008 into master Jun 17, 2021
@liujuncheng liujuncheng deleted the dev_user_op_set_default_is_dynamic_merge_master branch June 17, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants