Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant assert and check #5264

Merged
merged 24 commits into from Jun 25, 2021
Merged

remove redundant assert and check #5264

merged 24 commits into from Jun 25, 2021

Conversation

MARD1NO
Copy link
Contributor

@MARD1NO MARD1NO commented Jun 22, 2021 •
edited

移除错误的assert判断

原始的assert和相关check要求constant pad系列OP，pad要小于张量的宽和高，这是不需要的

后续还是把Pad2D系列ops拆成三个分别检查

constant pad需要有 float_value int_value 等attr

reflect pad需要pad小于输入张量的宽高, 不需要 float_value int_value 等attr

replicate pad 不需要 float_value int_value 等attr

虽然是关于attr是可以合并的，但我觉得容易误导，还是分开来检查

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@MARD1NO MARD1NO marked this pull request as draft June 22, 2021 07:45
@MARD1NO MARD1NO added bug eager op WIP work in progress labels Jun 22, 2021
@MARD1NO MARD1NO marked this pull request as ready for review June 22, 2021 08:26
@MARD1NO MARD1NO marked this pull request as draft June 22, 2021 08:26
@MARD1NO MARD1NO marked this pull request as ready for review June 23, 2021 02:05
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 23, 2021 07:47
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 23, 2021 09:19
@MARD1NO MARD1NO removed the WIP work in progress label Jun 23, 2021
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 23, 2021 10:36
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 24, 2021 05:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 06:28
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 07:50
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 10:35
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 13:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 14:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 15:37
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 24, 2021 16:54
@MARD1NO MARD1NO merged commit 2ddedd8 into master Jun 25, 2021
@MARD1NO MARD1NO deleted the fix_wrong_assert_in_pad branch June 25, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldpe2G Ldpe2G Ldpe2G approved these changes

@Flowingsun007 Flowingsun007 Awaiting requested review from Flowingsun007

@BBuf BBuf Awaiting requested review from BBuf

Assignees
No one assigned
Labels
automerge bug eager op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MARD1NO @CLAassistant @Ldpe2G @oneflow-ci-bot