New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tensor.to()/to_local() #5271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackhan
requested review from
lixinqi,
strint,
daquexian,
hjchen2 and
oneflow-ci-bot
June 22, 2021 09:22
strint
reviewed
Jun 23, 2021
strint
reviewed
Jun 23, 2021
strint
reviewed
Jun 23, 2021
strint
reviewed
Jun 23, 2021
strint
reviewed
Jun 23, 2021
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Show resolved
Hide resolved
hjchen2
reviewed
Jun 23, 2021
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Outdated
Show resolved
Hide resolved
hjchen2
reviewed
Jun 23, 2021
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Outdated
Show resolved
Hide resolved
…support_tensor_to/to_local Conflicts: oneflow/core/framework/tensor.h
…support_tensor_to/to_local
…support_tensor_to/to_local Conflicts: oneflow/core/framework/op_expr.cpp oneflow/core/framework/tensor.h
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 5, 2021 02:11
daquexian
reviewed
Aug 2, 2021
Speed stats:
|
daquexian
approved these changes
Aug 2, 2021
int64_t cur_parallel_id = | ||
CHECK_JUST(parallel_desc->ParallelId4MachineDeviceId(cur_machine_id, cur_machine_id)); | ||
if (cur_parallel_id != root) { | ||
Memset<DeviceType::kGPU>(ctx->device_ctx(), out->mut_dptr(), 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是什么原因,这个 op 名是 reduce,但 reduce 本身是不包含这个置零的操作的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个逻辑要删除,之前陈旧的想法有点问题
CI failed, removing label automerge |
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持local_tensor.to(...),以及对称模式下 gpu版本local_tensor.to_consistent(...),示例代码如下:
0号进程演示
1号进程演示