Add BUILD_BYPRODUCTS for ExternalProject_Add #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
好主意，我把用 ninja 编译的测试改成单步编译的 |
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
daquexian
approved these changes
Jun 29, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复在使用像 Ninja 这种 generator 的时候因为没标记 byproduct 而不能一次编译所有 target 的问题