add pixelshufflev2 module #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YongtaoShi
commented
Jul 5, 2021
•
YongtaoShi
commented
|
|
||
| .. math:: | ||
| H_{out} = H_{in} \times \text{upscale_factor} | ||
| H_{out} = H_{in} \times \text{h_upscale_factor} |
There was a problem hiding this comment.
我看.. math::写了3次，要不试试只写一次？
| @@ -36,20 +38,21 @@ class PixelShuffle(Module): | |||
| by Shi et. al (2016) for more details. | |||
|
|
|||
| Args: | |||
| upscale_factor (int): factor to increase spatial resolution by | |||
| h_upscale_factor (int): factor to increase height spatial resolution by | |||
There was a problem hiding this comment.
upscale_factor参数不应该去掉吧，这个PixelShufflev2功能是PixelShufflev的超集，应该保留upscale_factor，默认和pytorch对齐，h_upscale_factor、w_upscale_factor可以设置optianal，都传了，表示使用v2版本
There was a problem hiding this comment.
意思是总共3个参数吗？但是使用v2版本需要传3个参数，就有点奇怪了。
现在的逻辑是如果只传入h_upscale_factor，默认w_upscale_factor=h_upscale_factor，对于用户来讲是对齐的，只是变量名字有点区别。
There was a problem hiding this comment.
嗯，我感觉已有的变量名字需要完全对齐，多出来的增量的是可以接受的
There was a problem hiding this comment.
意思是upscale_factor参数至少不应该去掉
Flowingsun007
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.