Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiClientSessionContext #5421

Merged
merged 10 commits into from Jul 9, 2021
Merged

MultiClientSessionContext #5421

merged 10 commits into from Jul 9, 2021

Conversation

chengtbf
Copy link
Contributor

@chengtbf chengtbf commented Jul 7, 2021 •
edited

提供 C++ 端的 Multi-Client 下的全局唯一的 Session Context，负责：

  • 初始化 Session 和 跨 Runtime 的全局对象生命周期
  • nn.Graph 的多次实例化 job name 命名
  • [TODO] 跨 runtime 的内存复用，Lazy 内存块申请与释放
  • [TODO] （可能需要记录并提供 NNGraph 的索引？）

@chengtbf chengtbf added this to the v0.5.0 milestone Jul 7, 2021
@chengtbf chengtbf marked this pull request as ready for review July 8, 2021 12:15
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 9, 2021 05:46
@chengtbf
Copy link
Contributor Author

chengtbf commented Jul 9, 2021

这个 PR 看看还有没有问题？@strint @leaves-zwx

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 10:51
@oneflow-ci-bot oneflow-ci-bot merged commit d597cc2 into master Jul 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_cc_multi_client_sessctx branch July 9, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strint strint strint approved these changes

@leaves-zwx leaves-zwx Awaiting requested review from leaves-zwx

Assignees
No one assigned
Labels
automerge feature interface system
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chengtbf @strint @oneflow-ci-bot