export Tensor only to python #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackhan
reviewed
Jul 9, 2021
Comment on lines
218
to
219
| .def(py::init(&TensorExportUtil<MirroredTensor>::MakeTensor)) | ||
| .def(py::init(&TensorExportUtil<ConsistentTensor>::MakeTensor)) |
There was a problem hiding this comment.
这两个方法返回的是子类的shared_ptr，python不认识，会出错
daquexian
reviewed
Jul 9, 2021
| #define DEFINE_TENSOR_METHOD(T, type_proto) \ | ||
| .def("_copy_to_numpy_" #T, &ApiCopyMirroredTensorToNumpy<T>) \ | ||
| .def("_copy_from_numpy_" #T, &ApiCopyMirroredTensorFromNumpy<T>) | ||
| OF_PP_FOR_EACH_TUPLE(DEFINE_TENSOR_METHOD, POD_DATA_TYPE_SEQ) |
oneflow/python/framework/tensor.py
Outdated
| oneflow._oneflow_internal.ConsistentTensor, | ||
| oneflow._oneflow_internal.LocalTensor, | ||
| ), | ||
| (oneflow._oneflow_internal.ConsistentTensor, oneflow._oneflow_internal.Tensor,), |
There was a problem hiding this comment.
这里的 ConsistentTensor 可以删掉了
…into refactor_tensor_api
daquexian
approved these changes
Jul 9, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…oneflow into refactor_tensor_api
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
fix bug
fix bug
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
fix bug
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不再导出LocalTensor和ConsistentTensor。
只导出基类的Tensor类。