Refine module test using auto test by yaochi #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doombeaker
changed the title
…nc/oneflow into refine_autotest_yaochi
BBuf
reviewed
Jul 15, 2021
| @@ -20,6 +20,7 @@ | |||
|
|
|||
| import oneflow.experimental as flow | |||
There was a problem hiding this comment.
我感觉这些数学有关的操作应该统一放到test_math_ops.py里面，没必要单独开文件了，迟哥觉得呢
There was a problem hiding this comment.
是的，按道理应该不要分成多个文件。
现在这样做，是因为之前多人分工，由于大家的编程习惯难同意，同时编辑一个文件，会反复造成 conflict。为了降低沟通成本，就让大家各自开文件。
最近 python 算子层的工作还没告一段落（还需要改 inplace）。等这个弄完，我再统一过一遍汇总吧，你看可以么。
BBuf
approved these changes
Jul 15, 2021
doombeaker
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
完成 #5352 分配到我的任务。
var 的测试过程中，发现后向有问题，这个PR中就不重构， 后续单独提交PR，修复 var 的后向问题，并且重构 var 的测试。