implementation of constantpad-3d op #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flowingsun007
added
api
bottleneck
doombeaker
reviewed
Jul 19, 2021
| @@ -0,0 +1,66 @@ | |||
| /* | |||
There was a problem hiding this comment.
这个系列的文件名，叫做 pad3d_xxxx ，改作全称的 constantpad3d_xxxx 会不会更好。
还有就是，依照命名的约定，我们一般不用 xxx_kernels_util.h(cpp,cu) 而是 xxx_kernel_util.h(cpp,cu) 也就是 util 里的 kernel 不用复数。
（目前合到 master 里的只有一个用了 xxx_kernels_util，应该是review时的漏网之鱼
BBuf
reviewed
Jul 19, 2021
| return static_cast<int8_t>(integral); | ||
| } | ||
|
|
||
| template<> |
BBuf
reviewed
Jul 19, 2021
| const int64_t d_idx = 2; | ||
| const int64_t h_idx = 3; | ||
| const int64_t w_idx = 4; | ||
| // padding vector: [left, right, top, bottom, font, back] |
BBuf
reviewed
Jul 19, 2021
| const NdIndexOffsetHelper<int64_t, 5>& index_helper, const ShapeView& x_shape, | ||
| const ShapeView& y_shape, const std::vector<int64_t>& padding, | ||
| IN_T constant_value) { | ||
| // for NCDHW format input tensor, index of n,c,d,h,w is 0,1,2,3,4 |
BBuf
reviewed
Jul 19, 2021
| const int64_t d_idx = 2; | ||
| const int64_t h_idx = 3; | ||
| const int64_t w_idx = 4; | ||
| // padding vector: [left, right, top, bottom, font, back] |
BBuf
reviewed
Jul 19, 2021
| .Input("dy", op.GetGradTensorWithOpOutput("y", 0)) | ||
| .Output("dx") | ||
| .Attr("padding", op.attr<std::vector<int64_t>>("padding")) | ||
| .Attr("floating_value", op.attr<double>("floating_value")) |
There was a problem hiding this comment.
带这两个attr的意义是什么呢？在实现的时候可以做自动类型推断吧。
There was a problem hiding this comment.
这个主要和2d系列的保持了对齐（后面要改的话，提另一个统一改吧
| index_helper.OffsetToNdIndex(num, n, c, d, h, w); | ||
|
|
||
| const int64_t src_num = n_channel * x_depth * x_height * x_width; | ||
| if (pad_font <= d && d < pad_font + x_depth && w >= pad_left && w < x_width + pad_left |
BBuf
approved these changes
Jul 19, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constantpad 3d 的op实现包括：