Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align reshape input param with pytorch #5804

Merged
merged 36 commits into from
Aug 13, 2021
Merged

align reshape input param with pytorch #5804

merged 36 commits into from
Aug 13, 2021

Conversation

BBuf
Copy link
Contributor

@BBuf BBuf commented Aug 9, 2021

对齐Tensor.reshape的输入,不需要输入参数多包一层()。由于Tensor.reshape和flow.reshape输入参数的形式不同,前者是*shape,后者是shape所以docstring不能共用,这里修改了一下Tensor.reshape的docstring。

@BBuf BBuf requested a review from Flowingsun007 August 9, 2021 06:35
@BBuf BBuf requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 9, 2021 06:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 9, 2021 08:12
@github-actions github-actions bot removed the automerge label Aug 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

CI failed, removing label automerge

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 9, 2021 08:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 03:55
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 12, 2021 10:31
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 10:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 12:26
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 13:52
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 15:40
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 17:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 19:54
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 21:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 23:00
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 13, 2021 00:13
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.1ms (= 7004.1ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.2ms (= 6411.4ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 140.1ms / 128.2ms)

PyTorch resnet50 time: 83.7ms (= 4187.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.8ms (= 3737.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.7ms / 74.8ms)

PyTorch resnet50 time: 57.6ms (= 2878.0ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 48.3ms (= 2412.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 57.6ms / 48.3ms)

PyTorch resnet50 time: 48.5ms (= 2427.1ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.4ms (= 1970.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 48.5ms / 39.4ms)

PyTorch resnet50 time: 42.9ms (= 2144.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.1ms (= 1957.0ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 42.9ms / 39.1ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 31161f6 into master Aug 13, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_reshape_bug branch August 13, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants