-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argwhere bug #5816
Merged
Merged
Fix argwhere bug #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves-zwx
reviewed
Aug 9, 2021
size.to_local().numpy().item() | ||
if size.is_consistent | ||
else size.numpy().item() | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的处理我想了下,也会有问题,argwhere 应该也不能支持 input 为 consistent,因为这个计算求出来的 res 里面的 nd-index 一定是 local 的,size 也是。所以改成:
if input.is_consistent:
raise ValueError("A consistent tensor can not be applied to argwhere, and use `tensor.to_local()` to convert it to local tensor first.")
(res, size) = flow.F.argwhere(input, dtype=dtype)
if input.is_lazy:
raise NotImplementedError
# return flow.F.sync_dynamic_resize(res, size, dim=0)
else:
slice_tup_list = [(0, size.numpy().item(), 1)]
return flow.slice(res, slice_tup_list=slice_tup_list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
leaves-zwx
approved these changes
Aug 10, 2021
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决下面的问题: