Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename OpExprInterpState to AutoGradCaptureState #5918

Merged
merged 14 commits into from
Aug 19, 2021

Conversation

simonJJJ
Copy link
Contributor

No description provided.

@@ -33,10 +33,10 @@ class NdSbp;

namespace one {

class OpExprInterpState {
class AutoGradCaptureState {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这个挪到op_expr_grad.h文件里去?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

@simonJJJ simonJJJ requested a review from hjchen2 August 17, 2021 08:49
@@ -18,40 +18,57 @@ limitations under the License.
#define ONEFLOW_CORE_FRAMEWORK_OP_EXPR_GRAD_FUNCTION_H_

#include "oneflow/core/common/auto_registration_factory.h"
#include "oneflow/core/framework/op_interpreter.h" // OpExprInterpState
#include "oneflow/core/framework/op_interpreter.h" // AutoGradCaptureState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉注释

@oneflow-ci-bot oneflow-ci-bot self-requested a review August 18, 2021 16:50
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 18, 2021 17:10
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 18, 2021 17:10
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 18, 2021 19:27
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 18, 2021 20:37
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 18, 2021 21:35
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 18, 2021 23:28
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 18, 2021 23:28
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 19, 2021 00:49
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 149.8ms (= 7490.2ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.6ms (= 6429.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 149.8ms / 128.6ms)

PyTorch resnet50 time: 86.3ms (= 4312.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.8ms (= 3741.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.15 (= 86.3ms / 74.8ms)

PyTorch resnet50 time: 66.0ms (= 3302.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 49.1ms (= 2452.5ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.35 (= 66.0ms / 49.1ms)

PyTorch resnet50 time: 80.8ms (= 4041.0ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 50.1ms (= 2503.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.61 (= 80.8ms / 50.1ms)

PyTorch resnet50 time: 64.5ms (= 3226.1ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 53.9ms (= 2695.0ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.20 (= 64.5ms / 53.9ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 19, 2021 02:16
@oneflow-ci-bot oneflow-ci-bot merged commit c2931ec into master Aug 19, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the rename_to_autogradcapturestate branch August 19, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants