Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clang tidy diff warnings-as-errors option #5989

Merged
merged 2 commits into from Aug 21, 2021

Conversation

daquexian
Copy link
Contributor

-warnings-as-errors 跳过 maybe-glog-fatal 检查、在 ci 中开启 warnings-as-errors

Signed-off-by: daquexian <daquexian566@gmail.com>
Copy link
Contributor

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oneflow-ci-bot oneflow-ci-bot self-requested a review August 21, 2021 10:50
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 141.2ms (= 7057.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.4ms (= 6420.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 141.2ms / 128.4ms)

PyTorch resnet50 time: 85.0ms (= 4248.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.9ms (= 3747.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 85.0ms / 74.9ms)

PyTorch resnet50 time: 58.7ms (= 2934.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.7ms (= 2383.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 58.7ms / 47.7ms)

PyTorch resnet50 time: 47.7ms (= 2382.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.5ms (= 1974.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.21 (= 47.7ms / 39.5ms)

PyTorch resnet50 time: 44.4ms (= 2220.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 36.4ms (= 1821.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 44.4ms / 36.4ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 21, 2021 11:30
@oneflow-ci-bot oneflow-ci-bot merged commit b1c67df into master Aug 21, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the update_clang_tidy_diff_option branch August 21, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants