New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python function wrapper. #6012
Conversation
@@ -121,7 +121,11 @@ | |||
namespace functional = one::functional; | |||
|
|||
ONEFLOW_API_PYBIND11_MODULE("F", m) {{ | |||
py::options options; | |||
options.disable_function_signatures(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
禁止pybind自动生成doc
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
""" | ||
from oneflow._oneflow_internal.F import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 F
名字空间,其实作用是对应了 torch 中的 torch._C
吧?
我们是未来会改成 _C
吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前感觉没太大必要,和torch的_C
也不是完全对应。torch的接口导出比较分散,有些直接导出到torch,有些是torch._C
,我们都统一到F
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的。
CI failed, removing label automerge |
Co-authored-by: Yao Chi <later@usopp.net>
CI failed, removing label automerge |
CI failed, removing label automerge |
Speed stats:
|
移除python中的function wrapper,并解决builtin function添加doc的问题。