Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add broadcast pow #6013

Merged
merged 9 commits into from
Aug 24, 2021
Merged

Conversation

mosout
Copy link
Contributor

@mosout mosout commented Aug 23, 2021

No description provided.

@@ -101,6 +101,18 @@
signature: "Tensor (Tensor x, Scalar alpha) => ScalarPow"
bind_python: False

- name: "broadcast_pow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是可以绑一下python.,其它的broadcast op都绑了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接仿照add接口重新写一下pow的接口吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方没有绑定python是因为迟哥之前把pow这个接口在oneflow/api/python/functional/python_functions.cpp导出了,在上述文件中导出的接口调用了scalar_pow和element-wise pow,所以我就没有导出而是直接替换了element-wise pow

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 24, 2021 02:48
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 24, 2021 02:49
@mosout mosout requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 24, 2021 04:11
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 24, 2021 05:01
@oneflow-ci-bot oneflow-ci-bot merged commit 5f52ee3 into Oneflow-Inc:master Aug 24, 2021
@mosout mosout deleted the add_broadcast_pow branch August 24, 2021 07:30
@mosout mosout mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants