Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip sync when abnormally exiting #6025

Merged
merged 7 commits into from Aug 24, 2021

Conversation

daquexian
Copy link
Contributor

在非正常退出时跳过退出时的多进程同步,避免出现次生 bug (例如另一个进程正常执行到了一个需要多进程同步的操作,就会产生死锁,并且会超时错误)

Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 24, 2021 12:10
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 24, 2021 15:43
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 24, 2021 16:31
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 24, 2021 17:23
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 24, 2021 18:24
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 24, 2021 19:58
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.7ms (= 7033.2ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.8ms (= 6391.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.7ms / 127.8ms)

PyTorch resnet50 time: 83.0ms (= 4151.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.4ms (= 3719.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.0ms / 74.4ms)

PyTorch resnet50 time: 55.0ms (= 2751.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.3ms (= 2363.6ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 55.0ms / 47.3ms)

PyTorch resnet50 time: 46.5ms (= 2323.1ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.6ms (= 2129.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 46.5ms / 42.6ms)

PyTorch resnet50 time: 44.5ms (= 2227.1ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 38.3ms (= 1916.5ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 44.5ms / 38.3ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 24, 2021 22:40
@oneflow-ci-bot oneflow-ci-bot merged commit 9d697b9 into master Aug 24, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the skip_sync_when_abnormal_exiting branch August 24, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants