Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BroadcastMatmulGrad bug #6168

Merged
merged 6 commits into from Sep 6, 2021
Merged

Fix BroadcastMatmulGrad bug #6168

merged 6 commits into from Sep 6, 2021

Conversation

wyg1997
Copy link
Contributor

@wyg1997 wyg1997 commented Sep 6, 2021

修复 #6057 引入的 BroadcastMatmul 后向错误的 bug

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 6, 2021 09:12
@wyg1997 wyg1997 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 6, 2021 10:20
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Sep 6, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review September 6, 2021 11:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 128.7ms (= 6433.3ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.2ms (= 7108.1ms / 50, input_shape=[16, 3, 224, 224])
Relative speed: 1.10 (= 142.2ms / 128.7ms)

OneFlow resnet50 time: 74.7ms (= 3737.0ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.5ms (= 4224.0ms / 50, input_shape=[8, 3, 224, 224])
Relative speed: 1.13 (= 84.5ms / 74.7ms)

OneFlow resnet50 time: 49.5ms (= 2473.0ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.4ms (= 2919.8ms / 50, input_shape=[4, 3, 224, 224])
Relative speed: 1.18 (= 58.4ms / 49.5ms)

OneFlow resnet50 time: 41.5ms (= 2074.8ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.4ms (= 2370.9ms / 50, input_shape=[2, 3, 224, 224])
Relative speed: 1.14 (= 47.4ms / 41.5ms)

OneFlow resnet50 time: 40.1ms (= 2003.4ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 43.4ms (= 2169.7ms / 50, input_shape=[1, 3, 224, 224])
Relative speed: 1.08 (= 43.4ms / 40.1ms)

OneFlow resnet50 time: 154.7ms (= 7737.2ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 162.1ms (= 8104.7ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
Relative speed: 1.05 (= 162.1ms / 154.7ms)

OneFlow resnet50 time: 100.8ms (= 5040.5ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 103.0ms (= 5148.4ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
Relative speed: 1.02 (= 103.0ms / 100.8ms)

OneFlow resnet50 time: 79.2ms (= 3959.7ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.0ms (= 3898.5ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
Relative speed: 0.98 (= 78.0ms / 79.2ms)

OneFlow resnet50 time: 71.7ms (= 3583.2ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 63.8ms (= 3187.6ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
Relative speed: 0.89 (= 63.8ms / 71.7ms)

OneFlow resnet50 time: 66.1ms (= 3304.5ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 59.8ms (= 2989.8ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
Relative speed: 0.90 (= 59.8ms / 66.1ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review September 6, 2021 14:02
@wyg1997 wyg1997 added the op label Sep 6, 2021
@wyg1997 wyg1997 merged commit 332c05c into master Sep 6, 2021
@wyg1997 wyg1997 deleted the fix-broadcast_matmul_grad_bug branch September 6, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants