[Draft ONLY] nn.Graph asymmetric input/output debug runnable #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev_cc_fix_pipeline_stage
…dev_cc_fix_pipeline_stage
…w-Inc/oneflow into dev_cc_fix_pipeline_stage
…dev_cc_fix_pipeline_stage
…low-Inc/oneflow into dev_cc_fix_src_tick
chengtbf
commented
Sep 10, 2021
| if (node->GetTaskType() == TaskType::kSrcSubsetTick) { | ||
| CHECK(rank_id2src_tick.emplace(node->machine_id(), node).second); | ||
| } else if (node->GetTaskType() == TaskType::kDstSubsetTick) { | ||
| CHECK(rank_id2dst_tick.emplace(node->machine_id(), node).second); |
There was a problem hiding this comment.
修复 BUG 1 ： dst tick 也需要保证 output 和 callback notify 的顺序。
chengtbf
commented
Sep 10, 2021
| const auto& op_name = nn_graph->outputs_op_names().at(i); | ||
| auto* mut_blob = eager_blob_object->mut_blob(); | ||
| if (IsEmptyComponentEagerBlobObject(eager_blob_object)) { |
There was a problem hiding this comment.
修复 BUG 2： 跳过没有本 rank 分量的 push / pull cb 构建 和 send
chengtbf
commented
Sep 10, 2021
| bool IsEmptyComponentEagerBlobObject( | ||
| const std::shared_ptr<vm::EagerBlobObject>& eager_blob_object) { | ||
| Blob* blob = eager_blob_object->mut_blob(); | ||
| if (blob && blob->shape().elem_cnt() > 0 && blob->dptr()) { |
There was a problem hiding this comment.
修复判断本 rank 分量是否存在的逻辑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
header_size == rhs->blob_desc().ByteSizeOfBlobHeader()报错 #6226 中提到的问题